Patch for issue 7378

[Zach Villers]

All - patch is attached.

https://pagure.io/fedora-infrastructure/issue/7378



diff --git a/playbooks/include/proxies-redirects.yml
b/playbooks/include/proxies-redirects.yml
index 3a108eda3..004b2d4dc 100644
--- a/playbooks/include/proxies-redirects.yml
+++ b/playbooks/include/proxies-redirects.yml
@@ -62,7 +62,7 @@
- role: httpd/redirect
shortname: jenkins
website: jenkins.fedorainfracloud.org
- target: https://jenkins-fedora-infra.apps.ci.centos.org
+ target: https://jenkins-fedora-infra.apps.ci.centos.org/$1

- role: httpd/redirectmatch
shortname: fpaste



Thanks,
Zach
#aikidouke

[Mikolaj Izdebski]

It's almost good, but the patch is not entirely correct.

Post by Zach Villers
- role: httpd/redirect
shortname: jenkins
website: jenkins.fedorainfracloud.org
- target: https://jenkins-fedora-infra.apps.ci.centos.org
+ target: https://jenkins-fedora-infra.apps.ci.centos.org/$1

What does $1 refer to? It's not needed.

[Zach Villers]

Post by Mikolaj Izdebski
It's almost good, but the patch is not entirely correct.

:) I think I'm going to borrow "It's almost good", as the sub-header for
my website.

I looked at the original ticket and inferred too much possibly. Or
perhaps I'm just not clear on how this redirect works. I see now this a
for an apache mod_proxy config? Maybe I was thinking this was for a
mod_rewrite?

Either way; new patch attached without the '$1'. Thanks for reviewing!

-Zach #aikdiouke

[Mikolaj Izdebski]

Post by Zach Villers
I looked at the original ticket and inferred too much possibly. Or
perhaps I'm just not clear on how this redirect works. I see now this a
for an apache mod_proxy config? Maybe I was thinking this was for a
mod_rewrite?

It is httpd/redirect role, the relevant template is
roles/httpd/redirect/templates/redirect.conf
It uses Redirect directive, which is implemented by mod_alias

Post by Zach Villers
Either way; new patch attached without the '$1'. Thanks for reviewing!

I've applied it and deployed. Thanks. In future please commit your
changes and then use "git format-patch" or "git send-email" to send
patch with full metadata, so that you can be credited properly.

[Zach Villers]

Post by Mikolaj Izdebski
I've applied it and deployed. Thanks. In future please commit your
changes and then use "git format-patch" or "git send-email" to send
patch with full metadata, so that you can be credited properly.
--
Mikolaj
_______________________________________________

Thanks again for the review and the direction. :)